From 0b5aa8283b074e88a1395dcdbbdbc49eed7a0bfa Mon Sep 17 00:00:00 2001
From: hjp <hjp@d47eeb7a-11fe-0310-b519-e5a4e12f9765>
Date: Tue, 15 Jul 2008 21:18:16 +0000
Subject: [PATCH] noted that dieing is suboptimal.

---
 lib/Simba/CA.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/Simba/CA.pm b/lib/Simba/CA.pm
index e0bf604..e8bd49c 100644
--- a/lib/Simba/CA.pm
+++ b/lib/Simba/CA.pm
@@ -597,6 +597,10 @@ sub store_file {
     if ($header =~ /^data (.*)/) {
         my $f2 = $self->parse($1);
         my $backup_filename = "$self->{this_backup}/$f->{name}";
+        # XXX - should not die unconditionally. At least some errors
+        # (e.g. "File name too long") are almost certainly specific to
+        # single files. We should report the error and continue with the
+        # next file.
         open(my $file_bfd, '>:raw', $backup_filename) or die "cannot open backup file $backup_filename: $!";
         my $size = $f2->{s};
         my $err;