From 1bbef0d1bc52396245e22a22cf09541a01448fdb Mon Sep 17 00:00:00 2001
From: "Peter J. Holzer" <hjp@hjp.at>
Date: Tue, 20 Mar 2018 19:56:45 +0100
Subject: [PATCH] Compute buttons only once

$q->self_url is surprisingly slow, so don't call it gratuitously.
---
 index.cgi | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/index.cgi b/index.cgi
index e6f4872..f06f459 100755
--- a/index.cgi
+++ b/index.cgi
@@ -280,18 +280,19 @@ sub print_itemlist {
         $html .= "<div class='$item_class' $langattr>\n";
         $html .= "<span class='itemno'>" . $item->{item_id} . "</span>\n";
         $html .= "<span class='issued'>" . strftime('%Y-%m-%d %H:%M:%S', localtime($item->{issued})) . "</span>\n";
+        my $mark_read_button = "";
+        my $mark_later_button = "";
         unless ($is_read) {
-            print_log("print_itemlist: \$q1=" . $q1->self_url . " (in loop)");
-            $html .= "<div class='op'><a href='" . $q->escapeHTML($q1->self_url) . "'>Mark read</a></div>\n";
-            $html .= "<div class='op'><a href='" . $q->escapeHTML($q_later->self_url) . "'>Show later</a></div>\n";
+            $mark_read_button = "<div class='op'><a href='" . $q->escapeHTML($q1->self_url) . "'>Mark read</a></div>\n";
+            $mark_later_button = "<div class='op'><a href='" . $q->escapeHTML($q_later->self_url) . "'>Show later</a></div>\n";
         }
+        $html .= $mark_read_button;
+        $html .= $mark_later_button;
         $html .= "<div class='feed'>" . $q->escapeHTML($item->{feed_title}) . "</div>\n";
         $html .= "<h2><a href='./?redir=" . $q->escapeHTML($item->{item_id}) . "'>" . $q->escapeHTML($item->{item_title}) . "</a></h2>\n";
         $html .= "<div class='content'>" . $scrubbed_content . "</div>\n";
-        unless ($is_read) {
-            $html .= "<div class='op'><a href='" . $q->escapeHTML($q1->self_url) . "'>Mark read</a></div>\n";
-            $html .= "<div class='op'><a href='" . $q->escapeHTML($q_later->self_url) . "'>Show later</a></div>\n";
-        }
+        $html .= $mark_read_button;
+        $html .= $mark_later_button;
         $html .= "<div class='end'></div>\n";
         $html .= "</div\n>";
         print $html;